Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use KO_YAML_FLAGS for multi-platform build #4770

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Use KO_YAML_FLAGS for multi-platform build #4770

merged 1 commit into from
Jan 22, 2021

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jan 22, 2021

Since acf65cf started using hack/generate-yamls.sh, the KO_FLAGS option
was not used correctly so --platform=all option was missed in release
manifest.

This patch fixes it.

Thank you @VIjayHP for reporting the issue.

Release Note

NONE

/cc @runzexia @n3wscott @slinkydeveloper

@nak3
Use KO_YAML_FLAGS for multi-platform build
d1682a2 
Since acf65cf started using hack/generate-yamls.sh, the KO_FLAGS option
was not used correctly so `--platform=all` option was missed in release
manifest.

This patch fixes it.

Thank you @VIjayHP for reporting the issue.
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 22, 2021
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Jan 22, 2021
@nak3
Copy link
Contributor Author

nak3 commented Jan 22, 2021 •
edited
Loading

Hi @n3wscott @slinkydeveloper

@VIjayHP tested ppc64le arch and found that v0.19.0 was deployed in his cluster but v0.20.0 failed to deploy all pods in https://github.com/knative/eventing/releases/download/v0.20.0/eventing-core.yaml due to exec format error.
I believe that this is the problem.

@codecov
Copy link

codecov bot commented Jan 22, 2021 •
edited
Loading

Codecov Report

Merging #4770 (d1682a2) into master (26a3bfa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4770   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files         291      291           
  Lines        8281     8281           
=======================================
  Hits         6729     6729           
  Misses       1143     1143           
  Partials      409      409

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26a3bfa...d1682a2. Read the comment docs.

@runzexia
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2021
@slinkydeveloper
Copy link
Contributor

/cherry-pick release-0.20

@knative-prow-robot
Copy link
Contributor

@slinkydeveloper: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@slinkydeveloper
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2021
@vaikas
Copy link
Contributor

vaikas commented Jan 22, 2021

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, slinkydeveloper, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 7123f45 into knative:master Jan 22, 2021
@knative-prow-robot knative-prow-robot mentioned this pull request Jan 22, 2021
Merged
@knative-prow-robot
Copy link
Contributor

@slinkydeveloper: new pull request created: #4771

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhongduo zhongduo mentioned this pull request Jan 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott Awaiting requested review from n3wscott

@runzexia runzexia Awaiting requested review from runzexia

@slinkydeveloper slinkydeveloper Awaiting requested review from slinkydeveloper

Assignees

@slinkydeveloper slinkydeveloper

@vaikas vaikas

@runzexia runzexia

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nak3 @runzexia @slinkydeveloper @knative-prow-robot @vaikas